Skip to content

feat: Add CentOS 8.0 binaries#2220

Merged
kyujin-cho merged 20 commits intomainfrom
topic/05-30-feat_add_centos8.0_binaries
Jun 16, 2024
Merged

feat: Add CentOS 8.0 binaries#2220
kyujin-cho merged 20 commits intomainfrom
topic/05-30-feat_add_centos8.0_binaries

Conversation

@jopemachine
Copy link
Copy Markdown
Member

@jopemachine jopemachine commented May 30, 2024

Partially fix https://github.com/lablup/giftbox/issues/677.

Due to the difference in the glibc version, we cannot run Backend.AI on the CentOS8 image.
So adding CentOS8 krunner binary is needed.

And this PR also adds build scripts for backend.ai-jail and backend.ai-hook.

Notes

version issue

The version centos8.0 may not be correct because higher compatible versions like centos8.1 exist.
However, when using the name centos8, the current find_artifacts function finds this value invalid and skips.

def find_artifacts(pattern: str) -> Mapping[str, str]:
artifacts = {}
for p in artifact_path.glob(pattern):
m = self._rx_distro.search(p.name)
if m is not None:
artifacts[m.group(1)] = p.name
return artifacts

Therefore, I think maybe we should use names like centos8.0 or centos8.x, or modify the implementation of the find_artifact.

zlib upgrade

It appears that ZLIB 1.2.11 is no longer distributed.
Therefore, the build-sftpserver.sh for CentOS 8.0 was built with ZLIB version 1.3.1.
But this PR does not include binary updates for other distributions.

Switching repository to the vault.centos.org

CentOS 8 support ended in late 2021, disabling its main repositories.
Switching to the vault.centos.org repository enables continued access to packages and updates for unsupported versions.

FROM centos:centos8
RUN sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-Linux-*

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jopemachine and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added the size:M 30~100 LoC label May 30, 2024
@jopemachine jopemachine changed the title feat: Add centos8.0 dropbear binaries feat: Add centos8.0 binaries May 30, 2024
@jopemachine jopemachine changed the title feat: Add centos8.0 binaries feat: Add CentOS 8.0 binaries May 30, 2024
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels May 30, 2024
@jopemachine jopemachine marked this pull request as ready for review June 3, 2024 00:45
@jopemachine jopemachine added this to the 24.03 milestone Jun 3, 2024
@jopemachine jopemachine requested a review from kyujin-cho June 3, 2024 02:08
Comment thread scripts/agent/build-jail.sh Outdated
Comment thread scripts/agent/build-libbaihook.sh Outdated
@kyujin-cho kyujin-cho enabled auto-merge (squash) June 16, 2024 04:32
@kyujin-cho kyujin-cho merged commit 4f60fae into main Jun 16, 2024
@kyujin-cho kyujin-cho deleted the topic/05-30-feat_add_centos8.0_binaries branch June 16, 2024 04:34
lablup-octodog pushed a commit that referenced this pull request Jun 16, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2220
lablup-octodog added a commit that referenced this pull request Jun 16, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>

Co-authored-by: Gyubong Lee <jopemachine@naver.com>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants