feat(BA-4838): add NoAuth strategy and BackendAIClientRegistry to webserver by fregataa · Pull Request #9595 · lablup/backend.ai

fregataa · 2026-03-03T04:09:34Z

Summary

Add NoAuth(AuthStrategy) to client/v2/auth.py that returns empty headers from sign(), for use by the webserver which has no real keypair
Replace anon_client_ctx / app["anon_client"] with client_registry_ctx / app["client_registry"] using BackendAIClientRegistry.create(config, NoAuth())
Extract build_forwarding_headers() as a reusable pure function and refactor fill_forwarding_hdrs_to_api_session() to use it internally

Test plan

Verify webserver starts without errors
Verify app["client_registry"] is accessible and properly initialized
Verify login/logout/update-password flows still work

Resolves BA-4838

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR introduces a persistent v2 anonymous Backend.AI client on the webserver app and refactors forwarding-header construction into a reusable helper, aligning request proxying behavior across different HTTP callers.

Changes:

Extract build_forwarding_headers(request) in web/auth.py and refactor fill_forwarding_hdrs_to_api_session() to use it.
Add anon_client_ctx() in web/server.py to create/close a persistent BackendAIAnonymousClient (v2) and register it on app["anon_client"] via AsyncExitStack.
Add a changelog entry documenting the new persistent anon client and header builder extraction.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`src/ai/backend/web/server.py`	Adds an async context manager to create/close a v2 anonymous client and registers it on the app lifecycle.
`src/ai/backend/web/auth.py`	Introduces `build_forwarding_headers()` and refactors existing session header population to use it.
`changes/9595.feature.md`	Documents the new persistent v2 anonymous client and forwarding header helper extraction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ai/backend/web/auth.py

src/ai/backend/web/server.py

src/ai/backend/web/auth.py

src/ai/backend/web/server.py

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/ai/backend/web/server.py

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

changes/9595.feature.md

src/ai/backend/client/v2/auth.py

ironAiken2

LGTM

Extract build_forwarding_headers() as a pure function in web/auth.py, refactor fill_forwarding_hdrs_to_api_session() to use it, and add anon_client_ctx() context manager registered as app["anon_client"]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…aders - Create aiohttp.ClientSession with TCPConnector(limit=connection_limit) for the anonymous client to match webserver concurrency settings - Fix docstring in build_forwarding_headers() to accurately describe usage - Remove redundant `if _headers:` guard since the dict is always non-empty Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…oAuth strategy - Add NoAuth(AuthStrategy) that returns empty headers from sign() - Replace anon_client_ctx/app["anon_client"] with client_registry_ctx/app["client_registry"] - Use BackendAIClientRegistry.create() as a single facade for auth and anon clients Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ndler - Add extra_headers support to BackendAIAuthClient._request() and typed_request() - Add extra_headers passthrough to AuthClient.update_password_no_auth() - Replace v1 APISession-based anonymous call with registry.auth.update_password_no_auth() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Clarify that the registry uses NoAuth strategy by reflecting it in the name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ironAiken2

LGTM

github-actions bot added the size:M 30~100 LoC label Mar 3, 2026

github-actions bot assigned fregataa Mar 3, 2026

github-actions bot added the comp:webserver Related to Web Server component label Mar 3, 2026

fregataa added a commit that referenced this pull request Mar 3, 2026

docs(BA-4838): Add changelog entry for PR #9595

f9fc6b6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fregataa added this to the 26.3 milestone Mar 3, 2026

fregataa marked this pull request as ready for review March 3, 2026 07:26

fregataa requested review from a team and Copilot March 3, 2026 07:26

Copilot started reviewing on behalf of fregataa March 3, 2026 07:26 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/ai/backend/web/auth.py Outdated Show resolved Hide resolved

src/ai/backend/web/server.py Outdated Show resolved Hide resolved

src/ai/backend/web/auth.py Outdated Show resolved Hide resolved

src/ai/backend/web/auth.py Outdated Show resolved Hide resolved

jopemachine reviewed Mar 3, 2026

View reviewed changes

src/ai/backend/web/server.py Show resolved Hide resolved

fregataa requested review from a team and jopemachine March 3, 2026 08:05

fregataa added a commit that referenced this pull request Mar 3, 2026

docs(BA-4838): Add changelog entry for PR #9595

416d68a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fregataa force-pushed the feature/BA-4838 branch 2 times, most recently from 15d42ea to db1555c Compare March 5, 2026 02:23

github-actions bot added the comp:client Related to Client component label Mar 5, 2026

fregataa changed the title ~~feat(BA-4838): Register persistent v2 anonymous client on webserver app~~ feat(BA-4838): add NoAuth strategy and BackendAIClientRegistry to webserver Mar 5, 2026

fregataa requested a review from ironAiken2 March 5, 2026 02:42

fregataa added a commit that referenced this pull request Mar 5, 2026

docs(BA-4838): Add changelog entry for PR #9595

be416d7

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fregataa force-pushed the feature/BA-4838 branch from e6b1205 to f2330ce Compare March 5, 2026 04:48

github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Mar 5, 2026

jopemachine reviewed Mar 5, 2026

View reviewed changes

src/ai/backend/web/server.py Show resolved Hide resolved

fregataa force-pushed the feature/BA-4838 branch from f2330ce to 6498dd7 Compare March 5, 2026 08:09

fregataa requested a review from jopemachine March 5, 2026 08:11

fregataa added a commit that referenced this pull request Mar 5, 2026

docs(BA-4838): Add changelog entry for PR #9595

b21547d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fregataa force-pushed the feature/BA-4838 branch from 6498dd7 to 28394b2 Compare March 5, 2026 08:16

fregataa requested a review from a team March 5, 2026 12:31

jopemachine reviewed Mar 6, 2026

View reviewed changes

changes/9595.feature.md Outdated Show resolved Hide resolved

jopemachine reviewed Mar 6, 2026

View reviewed changes

src/ai/backend/client/v2/auth.py Show resolved Hide resolved

ironAiken2 previously approved these changes Mar 6, 2026

View reviewed changes

fregataa dismissed ironAiken2’s stale review via 3d4dab4 March 6, 2026 04:58

fregataa requested a review from ironAiken2 March 6, 2026 04:59

fregataa and others added 8 commits March 6, 2026 14:01

docs(BA-4838): Add changelog entry for PR #9595

52fdf7f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

refactor(BA-4838): return CIMultiDict from build_forwarding_headers()

358fc55

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

refactor(BA-4838): rename client_registry to no_auth_client_registry

0c63e14

Clarify that the registry uses NoAuth strategy by reflecting it in the name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

update news fragment

ca2fae7

fregataa force-pushed the feature/BA-4838 branch from 3d4dab4 to ca2fae7 Compare March 6, 2026 05:01

jopemachine approved these changes Mar 6, 2026

View reviewed changes

ironAiken2 approved these changes Mar 6, 2026

View reviewed changes

fregataa merged commit c77e24f into main Mar 6, 2026
23 checks passed

fregataa deleted the feature/BA-4838 branch March 6, 2026 05:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BA-4838): add NoAuth strategy and BackendAIClientRegistry to webserver#9595

feat(BA-4838): add NoAuth strategy and BackendAIClientRegistry to webserver#9595
fregataa merged 8 commits intomainfrom
feature/BA-4838

fregataa commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ironAiken2 left a comment

Uh oh!

ironAiken2 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fregataa commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fregataa commented Mar 3, 2026 •

edited

Loading