perf: improve Sandbox timeouts and update 4.16.0 documentation - #7438
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates client-side tool execution timeouts and refreshes the 4.16.0-beta1 upgrade documentation, while also adjusting the dataset detail navigation UI for localization.
Changes:
- Increased MCP tool run timeout and added an explicit HTTP tool run timeout (both to 10 minutes).
- Updated 4.16.0-beta1 Chinese release notes and added/updated the English translation content.
- Updated dataset detail nav text to use an i18n key (but currently introduces a UI regression that needs fixing).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/app/src/web/core/app/api/mcpTools.ts | Extends MCP tool execution timeout. |
| projects/app/src/web/core/app/api/httpTools.ts | Adds explicit timeout for HTTP tool execution. |
| projects/app/src/pageComponents/dataset/detail/NavBar.tsx | Attempts to localize the “back” UI in dataset detail header (currently breaks dataset name display). |
| document/data/doc-last-modified.json | Refreshes doc modified timestamps/entries. |
| document/content/self-host/upgrading/4-16/41601.mdx | Updates CN 4.16.0-beta1 notes and adds proxy env var section (includes a code-fence typo). |
| document/content/self-host/upgrading/4-16/41601.en.mdx | Updates EN translation (includes a code-fence typo and several untranslated placeholders). |
Suppressed comments (3)
document/content/self-host/upgrading/4-16/41601.en.mdx:69
- This is the North American English release note, but the curl example still uses Chinese placeholders ("你的域名", "你的ROOT_KEY"). Please translate these placeholders to English to keep the doc consistent.
curl -X POST 'https://你的域名/api/admin/4160/initUserSandbox' \
-H 'Content-Type: application/json' \
-H 'rootkey: 你的ROOT_KEY' \
-d '{"dryRun":false}'
document/content/self-host/upgrading/4-16/41601.en.mdx:86
- This is the North American English release note, but the curl example still uses Chinese placeholders ("你的域名", "你的ROOT_KEY"). Please translate these placeholders to English to keep the doc consistent.
curl -X POST 'https://你的域名/api/admin/4160/initHttpToolSchema' \
-H 'Content-Type: application/json' \
-H 'rootkey: 你的ROOT_KEY' \
-d '{"dryRun":true}'
document/content/self-host/upgrading/4-16/41601.en.mdx:95
- This is the North American English release note, but the curl example still uses Chinese placeholders ("你的域名", "你的ROOT_KEY"). Please translate these placeholders to English to keep the doc consistent.
curl -X POST 'https://你的域名/api/admin/4160/initHttpToolSchema' \
-H 'Content-Type: application/json' \
-H 'rootkey: 你的ROOT_KEY' \
-d '{"dryRun":false}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AGENT_SANDBOX_PREVIEW_PROXY_URL=https://sandbox-proxy.example.com | ||
| Version 4.16.0 requires the proxy for static resource access. If your gateway supports WebSocket and HTTP traffic on the same port, you only need to expose one port. Otherwise, set `PREVIEW_PORT` to configure the HTTP port. | ||
|
|
||
| ```dotev |
|
|
||
| 4.16.0 需要依赖 proxy 进行静态资源代理访问，如果网关支持 ws 和 http 在同一个端口，则可以只开放一个端口。如果不支持，可以通过设置 `PREVIEW_PORT` 来设置 http 访问端口。 | ||
|
|
||
| ```dotev |
| curl -X POST 'https://你的域名/api/admin/4160/initUserSandbox' \ | ||
| -H 'Content-Type: application/json' \ | ||
| -H 'rootkey: 你的ROOT_KEY' \ | ||
| -d '{"dryRun":true}' |
| className="textEllipsis" | ||
| > | ||
| {datasetDetail.name} | ||
| {t('common:back')} |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5aecf5125
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```dotenv | ||
| # Browser-accessible HTTP(S) URL for Sandbox file previews | ||
| AGENT_SANDBOX_PREVIEW_PROXY_URL=https://sandbox-proxy.example.com | ||
| Version 4.16.0 requires the proxy for static resource access. If your gateway supports WebSocket and HTTP traffic on the same port, you only need to expose one port. Otherwise, set `PREVIEW_PORT` to configure the HTTP port. |
There was a problem hiding this comment.
For Docker/Compose deployments whose gateway cannot multiplex WebSocket and HTTP, setting PREVIEW_PORT=1007 as instructed still leaves previews inaccessible: document/public/deploy/sandbox_deploy/agent-proxy.yml only publishes 3006:1006 at lines 14–17, so the second listener is unreachable outside the container. This fallback must also instruct operators to publish and route the preview port (and adjust firewall rules where applicable), otherwise the newly required Sandbox previews fail in precisely the configuration described here.
Useful? React with 👍 / 👎.
| curl -X POST 'https://你的域名/api/admin/4160/initUserSandbox' \ | ||
| -H 'Content-Type: application/json' \ | ||
| -H 'rootkey: 你的ROOT_KEY' \ |
There was a problem hiding this comment.
In the North American English release notes, the newly added curl examples use 你的域名 and 你的ROOT_KEY; these Chinese placeholders recur in the formal-run and HTTP-tool commands as well. English-speaking operators are no longer told that they mean their domain and root key—the parent version used your-domain and YOUR_ROOT_KEY—so the required migration instructions are now partially untranslated. Keep the placeholders localized in the English document.
AGENTS.md reference: AGENTS.md:L72-L72
Useful? React with 👍 / 👎.
What changed
common.backtranslation.Why
These changes align the Sandbox tool behavior and documentation with the 4.16.0-beta1 release, while keeping the UI consistent across supported languages.
Validation
git diff --checkpassed.