Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe9e7e3959
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'en-US': LangEnum.en, | ||
| 'en-us': LangEnum.en | ||
| 'en-us': LangEnum.en, | ||
| 'ko-KR': LangEnum.ko_KR |
There was a problem hiding this comment.
Add case-insensitive and language-only Korean mappings rather than only the canonical spelling. getLangMapping looks up the lowercased value after this table, but the table has no ko-kr key, and its prefix fallback handles only zh and en; consequently common browser values such as ko or lowercase ko-kr resolve to the default zh-CN. Since useI18nLng initializes first-time visitors from navigator.language, affected Korean users are automatically switched to Simplified Chinese despite the new Korean resources.
Useful? React with 👍 / 👎.
| "enterprise_auth.error.task_not_found": "인증 작업이 존재하지 않거나 종료되었습니다", | ||
| "enterprise_auth.error.too_frequent": "시도 횟수가 너무 많습니다. 나중에 다시 시도해 주세요.", | ||
| "enterprise_auth_notice_benefit_advanced": "더 많은 프리미엄 기능을 갖춘 15일 Advanced 요금제 잠금 해제", | ||
| "enterprise_auth_notice_benefit_intro": "인증에 성공하면 계정이 자동으로 45만원 상당의 Advanced 혜택으로 업그레이드됩니다:", |
There was a problem hiding this comment.
Keep the source value and currency instead of translating RMB 450 as 45만원 (₩450,000). This string is rendered directly by EnterpriseAuthNoticeModal, so Korean users are promised a substantially different and much larger benefit than the 450元 shown by the source locale, with no locale-specific pricing logic supporting that change.
Useful? React with 👍 / 👎.
| "n_dataset_amount": "{{amount}}개 데이터셋 한도", | ||
| "n_dataset_size": "{{amount}}개 데이터셋 인덱스", | ||
| "n_max_upload_file_count": "최대 {{amount}}개 파일 업로드", | ||
| "n_max_upload_file_limit": "각 {{size}}MB, 최대 {{count}}개 파일 업로드", |
There was a problem hiding this comment.
Remove the literal MB after {{size}}. Every caller shown for this key passes a preformatted size—such as formatFileSize(maxSize), which already returns values like 50 MB—so the Korean upload and plan-limit text renders malformed output such as 50 MBMB.
Useful? React with 👍 / 👎.
Coverage Report
File CoverageNo changed files found. |
|
✅ Admin Preview Image Ready! 🕒 Time: 2026-08-22 00:58:00 (UTC+8) |
|
✅ Build and publish successful - Preview fastgpt Image: 🕒 Time: 2026-08-22 00:40:11 (UTC+8) |
Coverage Report
|
Add full Korean translation for the main app's product-facing i18n system (packages/web/i18n, shared by projects/app and projects/marketplace), which previously only supported en/zh-CN/zh-Hant. All 24 namespace files are translated with full key parity against the English source (3634 keys total). Register the new locale end-to-end: LangEnum/LocaleList/langMap (with a new Korea flag icon), next-i18next locales arrays in both projects/app and projects/marketplace, the browser-language-to-locale mapping in packages/web/i18n/utils.ts, and the shared-chat language switcher's locale list. Also harden getModelProvider() on both the client store and the server-side provider controller: they previously indexed a provider-name/avatar cache map built only for the pre-existing three locales, which would throw when called with any other locale (including the new 'ko') — now they gracefully fall back to the default provider info instead. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Archer <545436317@qq.com>
|
✅ Docs preview deployed 🔗 👀 Click here to visit preview 🕒 Time: 2026-08-22 00:36:39 (UTC+8) |
No description provided.