Skip to content

feat: add GitHub App installations and Desktop SDK auth#143

Merged
zjy365 merged 6 commits into
mainfrom
codex-github-app-installations
Jul 2, 2026
Merged

feat: add GitHub App installations and Desktop SDK auth#143
zjy365 merged 6 commits into
mainfrom
codex-github-app-installations

Conversation

@zjy365

@zjy365 zjy365 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • harden kubeconfig namespace verification by using a trusted Kubernetes API server instead of the kubeconfig-provided cluster server
  • require SEALOS_KUBERNETES_API_SERVER for out-of-cluster verification while using KUBERNETES_SERVICE_HOST/PORT automatically in cluster
  • tighten GitHub App namespace auth, template deploy auth, project persistence auth, and related tests
  • update API docs wording to remove admin namespace override language

Verification

  • bun test apps/ui/src/lib/request-kubeconfig-auth.test.ts apps/ui/src/lib/github-app/namespace-auth.test.ts apps/ui/src/app/api/templates/deploy/auth.test.ts
  • bun typecheck
  • bun check
  • cd apps/api && go test ./...

zjy365 added 3 commits July 1, 2026 20:57
Remove cookie and regionToken credential sources, route API authorization through Desktop SDK kubeconfig, and clean deployment docs/config.
returnPath: parseOAuthReturnPathParam(searchParams.get("next")),
});
const installationId = searchParams.get("installation_id");
if (!installationId) {
@zjy365 zjy365 changed the title Harden kubeconfig namespace auth Add GitHub App installations and Desktop SDK auth Jul 1, 2026
@zjy365 zjy365 changed the title Add GitHub App installations and Desktop SDK auth feat: add GitHub App installations and Desktop SDK auth Jul 1, 2026
@zjy365

zjy365 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

@devbox-review-dev smoke test: please inspect this PR and reply with a concise status only. Do not push code changes.

zjy365 added 3 commits July 2, 2026 14:29
…allations

# Conflicts:
#	apps/ui/src/lib/deploy-task/schema-bootstrap.ts
#	apps/ui/src/lib/deploy-task/service.ts
@zjy365 zjy365 merged commit 9866935 into main Jul 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants