Skip to content

fix resources controller Kubefile#3333

Merged
bxy4543 merged 1 commit into
labring:mainfrom
bxy4543:fix/resourcekubefile
Jun 13, 2023
Merged

fix resources controller Kubefile#3333
bxy4543 merged 1 commit into
labring:mainfrom
bxy4543:fix/resourcekubefile

Conversation

@bxy4543

@bxy4543 bxy4543 commented Jun 12, 2023

Copy link
Copy Markdown
Member

🤖 Generated by Copilot at 89b23e2

Summary

🐛🔄🚀

Fixed a bug in the Kubefiles of the resources and metering controllers that prevented the correct namespace from being used when deploying the manifests. Changed the CMD instruction to use double quotes for shell expansion.

Kubefile changes
Quoting for shell expansion
Autumn of errors

Walkthrough

  • Modify CMD instruction in Kubefile files to use double quotes for shell expansion (link, link)

@sealos-ci-robot

sealos-ci-robot commented Jun 12, 2023

Copy link
Copy Markdown
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 637
✅ Successful 302
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 334
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov

codecov Bot commented Jun 12, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (7eae15a) 72.97% compared to head (1c6eeb9) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3333   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bxy4543
bxy4543 force-pushed the fix/resourcekubefile branch from 89b23e2 to 1c6eeb9 Compare June 12, 2023 11:40
@bxy4543
bxy4543 merged commit 7185ae7 into labring:main Jun 13, 2023
@bxy4543
bxy4543 deleted the fix/resourcekubefile branch July 17, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants