test(preflight): fail TestPreflightAzure cleanly on errors#1840
Merged
Conversation
Use require.NoError instead of assert.NoError after azure.New and preflight.Run(). assert only records the failure and continues, so an auth error (e.g. an expired client secret) fell through to dereference a nil result, crashing the whole integration shard with a SIGSEGV nil pointer panic instead of a readable assertion failure. require stops the test at the error. Vendors testify/require.
lokesh-vadlamudi
marked this pull request as ready for review
June 23, 2026 19:16
lokesh-vadlamudi
enabled auto-merge (squash)
June 23, 2026 19:16
wsli-1
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the two error checks in
TestPreflightAzurefromassert.NoErrortorequire.NoError(afterazure.Newandpreflight.Run()).assert.NoErroronly records the failure and lets the test continue, so whenpreflight.Run()returns an error (e.g. an expired Azure client secret), execution fell through toresult.Caller.ObjectIDon anilresult and panicked:That SIGSEGV aborts the entire
integrationtest binary with exit code 2, taking down the whole shard instead of reporting a single readable test failure.require.NoErrorstops the test at the error, so the failure surfaces as:The value assertions below are left as
assert(they do not dereferencenilonceresultis non-nil).testify/requireis vendored since the repo builds with-mod=vendor.