ci: fix workflow parse error from #484 secret guard (LAC-3035) - #486
Merged
Conversation
… (LAC-3035) #484 used `secrets.CLAUDE_CODE_OAUTH_TOKEN` inside step-level `if:` expressions, which is a workflow parse error (jobless failed runs on every push to main). Evaluate the presence check once in job-level `env` (where secrets is allowed) and gate steps on the env var. Validated with actionlint. Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#484's step-level
if: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN != '' }}guards are a workflow parse error — thesecretscontext is not allowed inif:expressions. Every push to main now produces a jobless failed run of both Claude workflows (e.g. run 30050985047: "This run likely failed because of a workflow file issue").Fix: evaluate presence once in job-level
env(HAS_CLAUDE_OAUTH_TOKEN), gate steps onenv.HAS_CLAUDE_OAUTH_TOKEN. Validated withactionlint.Verification: after merge, PR #485 (throwaway) gets rebased to re-trigger
claude-review, which should pass with skipped steps + notice.