Skip to content

fix(deps): resolve 17 Dependabot advisories — vite, react-router, @babel/core (LAC-3048) - #487

Merged
lacymorrow merged 1 commit into
mainfrom
LAC-3048/dependabot-dep-upgrades
Jul 23, 2026
Merged

fix(deps): resolve 17 Dependabot advisories — vite, react-router, @babel/core (LAC-3048)#487
lacymorrow merged 1 commit into
mainfrom
LAC-3048/dependabot-dep-upgrades

Conversation

@lacymorrow

Copy link
Copy Markdown
Owner

Summary

Resolves LAC-3048 — 17 open Dependabot alerts (10 high, 5 moderate, 2 low).

Triage findings

The 17 alerts collapse to 4 packages, double-counted across pnpm-lock.yaml and package-lock.json — root lockfiles deleted from main in June 2025. GitHub's dependency graph retains stale manifest entries, so newly published advisories still fire against them. The alerts can never auto-resolve (nothing rescans deleted files), but the same vulnerable versions were genuinely present in the live bun.lock, so the upgrades are real fixes, not bookkeeping:

Package Before After Advisories
vite 6.3.5 6.4.3 GHSA-fx2h-pf6j-xcff (high, server.fs.deny bypass), GHSA-v6wh-96g9-6wx3 (moderate, NTLM hash disclosure) — both Windows dev-server only
react-router(-dom) 7.6.3 7.18.1 GHSA-49rj-9fvp-4h2h (high, turbo-stream RCE), GHSA-rxv8-25v2-qmq8 + GHSA-8x6r-g9mw-2r78 (high, DoS), GHSA-2j2x-hqr9-3h42 (moderate, open redirect), GHSA-f22v-gfqf-p8f3 (moderate, stored XSS) — all SSR/framework-mode; Juno uses client-side routing only, so exploitability was low, but upgrade is cheap
turbo-stream 2.4.0 (vendored) removed from tree transitive of react-router
@babel/core 7.28.0 7.29.7 GHSA-4x5r-pxfx-6jf8 (low, arbitrary file read) — also bumped in backend-server/package-lock.json (7.27.4 → 7.29.7, same advisory, not yet flagged)

Collateral changes

  • bun install deterministically refreshed other in-range transitive deps when package.json changed (streamdown 2.2→2.5, vitest 3.1→3.2.7, @vitejs/plugin-react 4.3→4.7). Any fresh install would produce the same resolution.
  • reasoning.tsx: streamdown 2.5 tightened the dir prop type, exposing a latent bug — CollapsibleContent props were double-spread into both CollapsibleContent and Streamdown. Removed the second spread (matches upstream ai-elements).

Follow-up (not in this PR)

The 17 stale-manifest alerts will be dismissed with an explanatory comment after merge, since they reference deleted lockfiles and cannot auto-close.

Testing

  • bun run build (tsc + vite) — passes
  • npm test -- --run — 36/36 pass
  • No Rust changes → cargo check not applicable (npm-only diff)

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

…visories (LAC-3048)

- vite 6.3.5 -> 6.4.3 (GHSA-fx2h-pf6j-xcff server.fs.deny bypass, GHSA-v6wh-96g9-6wx3 launch-editor NTLM hash disclosure)
- react-router / react-router-dom 7.6.3 -> 7.18.1 (GHSA-49rj-9fvp-4h2h turbo-stream RCE, GHSA-rxv8-25v2-qmq8 + GHSA-8x6r-g9mw-2r78 DoS, GHSA-2j2x-hqr9-3h42 open redirect, GHSA-f22v-gfqf-p8f3 stored XSS); vendored turbo-stream v2 removed from tree
- @babel/core 7.28.0 -> 7.29.7 in bun.lock and backend-server lockfile (GHSA-4x5r-pxfx-6jf8 arbitrary file read)
- reasoning.tsx: stop spreading CollapsibleContent props into Streamdown (streamdown 2.5 tightened dir prop type; double-spread was a latent bug)

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@lacymorrow
lacymorrow force-pushed the LAC-3048/dependabot-dep-upgrades branch from 9e0e0ea to e139fc9 Compare July 23, 2026 22:59
@lacymorrow
lacymorrow merged commit 9cc7244 into main Jul 23, 2026
4 checks passed
@lacymorrow
lacymorrow deleted the LAC-3048/dependabot-dep-upgrades branch July 23, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant