Improve camera calibration apps#1986
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
- Coverage 48.74% 48.71% -0.04%
==========================================
Files 532 532
Lines 69401 69404 +3
Branches 32432 32434 +2
==========================================
- Hits 33831 33809 -22
- Misses 31425 31443 +18
- Partials 4145 4152 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… version - Update preprocessor conditions in visp-calibrate-camera.cpp to allow compilation with OpenCV versions older than 4.7.0. - Make the ChArUco detector optional by wrapping related code and dependencies with #if (VISP_HAVE_OPENCV_VERSION >= 0x040700) checks. - Update extractCalibrationPoints signature and calls to conditionally include the CharucoDetector pointer. - Add fallback logic in calibration-helper.hpp to handle pattern detection without ChArUco for older OpenCV environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.