Tuto display - #2012
Merged
Merged
Conversation
sjourdro
marked this pull request as draft
September 8, 2026 07:22
sjourdro
marked this pull request as ready for review
September 8, 2026 08:18
fspindle
reviewed
Sep 9, 2026
fspindle
reviewed
Sep 9, 2026
sjourdro
marked this pull request as draft
September 9, 2026 07:37
sjourdro
marked this pull request as ready for review
September 9, 2026 07:47
Contributor
|
@sjourdro when you link towards a Python class, you should use: instead of a link towards the online documentation, it permits to work with local files only. You can also link towards a function such as: in this case I would suggest to keep the full denomination. See this post to link towards a method of a class. Thank you in advance for applying the required changes =) |
sjourdro
marked this pull request as draft
September 9, 2026 08:29
sjourdro
marked this pull request as ready for review
September 9, 2026 09:49
sjourdro
marked this pull request as draft
September 9, 2026 09:51
sjourdro
marked this pull request as ready for review
September 9, 2026 10:01
rolalaro
approved these changes
Sep 9, 2026
rolalaro
left a comment
Contributor
There was a problem hiding this comment.
The links are now correctly using Sphinx cross references, and the Python code have the expected behavior. Well done !
sjourdro
marked this pull request as draft
September 9, 2026 13:15
sjourdro
marked this pull request as ready for review
September 9, 2026 13:31
sjourdro
marked this pull request as draft
September 9, 2026 13:33
sjourdro
marked this pull request as ready for review
September 9, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finished the tutorial on displaying images.
The links are all correct.
The commands work and the code examples give the expected results.
I am not totally sure on the explications I gave however.
Please review it and give your impressions.
@fspindle @rolalaro