Added chat and chat/health handler registration, dispatch, and testing - #9
Conversation
neagualexa
left a comment
neagualexa
left a comment
There was a problem hiding this comment.
good to have the tests, I presume a next step is to add similar test for evaluate too (in the new test files from tests/io)?
| self._methods = { | ||
| name: jsonrpc_handler(self, name) for name in ["eval", "preview", "healthcheck"] | ||
| name: jsonrpc_handler(self, name) | ||
| for name in ["eval", "preview", "healthcheck", "chat", "chat/health"] |
There was a problem hiding this comment.
so this was for legacy evaluate?
There was a problem hiding this comment.
It's also for muEd, shimmy works as a protocol facade, it converts muEd into what the evaluation function expects.
There was a problem hiding this comment.
so then would it be worth using the mued naming for consistency?
There was a problem hiding this comment.
Switching the term here would most likely break the legacy implementation. Currently, the shimmy facade takes muEd and basically converts to legacy, as this was a simpler implementation and no additional muEd functionality is currently required.
2 participants
Request
Implement chat functionality into Shimmy.
Solution
This is one aspect of the multi-part solution for implementing chat in Shimmy.
This PR handles the shared toolkit updates: