feat(l1): persist bad blocks in db. #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
force-pushed
the
persist-bad-blocks
branch
from
5f07ffd to
747d7cd
Compare
…to persist-bad-blocks
ElFantasma
approved these changes
Apr 3, 2025
Contributor
ElFantasma
left a comment
ElFantasma
left a comment
There was a problem hiding this comment.
This LGTM, but don't have an opinion on whether we should store invalid ancestors on db or in memory. I guess it depends on if we want the data to survive app restart or not, right?
fmoletta
reviewed
Apr 3, 2025
fmoletta
reviewed
Apr 3, 2025
Comment on lines
233
to
234
| .get_invalid_ancestor(head_block.parent_hash) | ||
| .unwrap() |
Contributor
There was a problem hiding this comment.
Is it safe to unwrap here?
fmoletta
reviewed
Apr 3, 2025
fmoletta
reviewed
Apr 3, 2025
rodrigo-o
reviewed
Apr 3, 2025
Comment on lines
240
to
244
| } else { | ||
| // Check if there is an ongoing sync before applying the forkchoice | ||
| match context.sync_status()? { | ||
| // Apply current fork choice | ||
| SyncStatus::Inactive => { |
Collaborator
There was a problem hiding this comment.
Probably for another PR, but this change in addition to the refactor of the SyncManger might allow us to enable some additional Invalid NewPayload hive test.
fmoletta
reviewed
Apr 8, 2025
Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Don't have to rely on the global mutex of the Syncer to fetch invalid blocks **Description** Not sure if this is the ultimate solution, Im still unsure if it is better to store invalid ancestors in db or in memoy --------- Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Don't have to rely on the global mutex of the Syncer to fetch invalid blocks
Description
Not sure if this is the ultimate solution, Im still unsure if it is better to store invalid ancestors in db or in memoy