-
Notifications
You must be signed in to change notification settings - Fork 142
feat(l1): write state nodes in batches during state healing #2309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Mar 27, 2025
ElFantasma
approved these changes
Mar 27, 2025
rodrigo-o
approved these changes
Mar 27, 2025
Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
…atches' into state-healing-write-nodes-in-batches
…to state-healing-write-nodes-in-batches
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ass#2309) **Motivation** In a similar fashion to lambdaclass#2288, this PR aims to reduce the time spent writing data to the DB by writing data in batches. In this case the nodes received during storage healing are written all at once using the `write_node_batch` method introduced in lambdaclass#2288 <!-- Why does this pull request exist? What are its goals? --> **Description** * Refactor state healer code to write all nodes for a trie in a single operation <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number --------- Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In a similar fashion to #2288, this PR aims to reduce the time spent writing data to the DB by writing data in batches. In this case the nodes received during storage healing are written all at once using the
write_node_batchmethod introduced in #2288Description
Closes #issue_number