fix(l2): config error handling #2339
Merged
+76
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
fborello-lambda
approved these changes
Mar 27, 2025
Contributor
fborello-lambda
left a comment
fborello-lambda
left a comment
There was a problem hiding this comment.
Nice, the error message wasn't clear enough.
| "Could not find crates/l2/configs/{0} | ||
| Have you tried copying the provided example? Try: | ||
| cp {manifest_dir}/configs/*_example.toml {manifest_dir}/configs/*.toml | ||
| cp {manifest_dir}/configs/{1}_config_example.toml {manifest_dir}/configs/{1}_config.toml |
ilitteri
changed the title
jrchatruc
approved these changes
Mar 28, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation**
In a previous PR, the configuration file error handling was updated, and
the help messages stopped being helpful. This PR aims to make these
error messages useful again and improve their handling.
The current help message does not work:
```Shell
Error parsing the .toml configuration files: Could not find crates/l2/configs/config.toml
Have you tried copying the provided example? Try:
cp /Users/ivanlitteri/Repositories/lambdaclass/ethrex/crates/l2/configs/*_example.toml /Users/ivanlitteri/Repositories/lambdaclass/ethrex/crates/l2/configs/*.toml
Error: ConfigError(TomlParserError(TomlFileNotFound("config.toml")))
make: *** [deploy-l1] Error 1
➜ l2 git:(main) ✗ cp /Users/ivanlitteri/Repositories/lambdaclass/ethrex/crates/l2/configs/*_example.toml /Users/ivanlitteri/Repositories/lambdaclass/ethrex/crates/l2/configs/*.toml
cp: /Users/ivanlitteri/Repositories/lambdaclass/ethrex/crates/l2/configs/sequencer_config_example.toml is not a directory
```
**Description**
- Add a prefix `sequencer_` to the sequencer config file to be
consistent with the prover client config file and update its references.
- Pass `ConfigMode` to the `toml` errors to make the help messages
helpful again, and implement `Debug` and `Display` for this on it.
- Make the `toml` parsing error explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In a previous PR, the configuration file error handling was updated, and the help messages stopped being helpful. This PR aims to make these error messages useful again and improve their handling.
The current help message does not work:
Description
sequencer_to the sequencer config file to be consistent with the prover client config file and update its references.ConfigModeto thetomlerrors to make the help messages helpful again, and implementDebugandDisplayfor this on it.tomlparsing error explicit.