Skip to content

Conversation

@JackDrogon
Copy link

@JackDrogon JackDrogon commented Mar 28, 2025

Motivation

fix build l1 client in Makefile

Description

change cargo build --workspace to cargo build in Makefile to build l1 client without l2 prover

Closes #issue_number

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon JackDrogon requested a review from a team as a code owner March 28, 2025 07:56
@JackDrogon JackDrogon changed the title fix(chore): fix build l1 client in Makefile fix(l1): fix build l1 client in Makefile Mar 28, 2025
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch!

tomip01
tomip01 previously approved these changes Mar 28, 2025
@tomip01 tomip01 dismissed their stale review March 28, 2025 21:09

This wasn't what the build rule was intended. With this, only some crates are built

@mpaulucci
Copy link
Collaborator

Fixed on #2372

@mpaulucci mpaulucci closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants