fix(l2): increase L1 tx receipt retrieve retries #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses flaky L2 integration tests in CI caused by changes to L1 dev node transaction inclusion behavior. The fix increases the retry count for retrieving L1 transaction receipts from 5 to 50 attempts, allowing sufficient time for the L1 dev node to include transactions.
Key Changes:
- Increased transaction receipt retrieval retry count from 5 to 50 across all L2 integration tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| let deposit_tx_receipt = | ||
| ethrex_l2_sdk::wait_for_transaction_receipt(deposit_tx_hash, l1_client, 5).await?; | ||
| ethrex_l2_sdk::wait_for_transaction_receipt(deposit_tx_hash, l1_client, 50).await?; |
There was a problem hiding this comment.
The retry count '50' is a magic number repeated across multiple tests. Consider extracting this to a named constant (e.g., const L1_TX_RECEIPT_MAX_RETRIES: u64 = 50;) at the module level to improve maintainability and make it easier to adjust if needed in the future.
Suggested change
| ethrex_l2_sdk::wait_for_transaction_receipt(deposit_tx_hash, l1_client, 50).await?; | |
| ethrex_l2_sdk::wait_for_transaction_receipt(deposit_tx_hash, l1_client, L1_TX_RECEIPT_MAX_RETRIES).await?; |
gianbelinche
approved these changes
Nov 14, 2025
jrchatruc
approved these changes
Nov 14, 2025
tomip01
approved these changes
Nov 14, 2025
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
**Motivation** lambdaclass#5337 introduced some unexpected behaviour in the L1 dev node tx inclusion. This made flaky L2 integration tests in the CI. **Description** Increase the number of retries to retrieve an L1 tx receipt to a number high enough for the L1 dev to include txs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#5337 introduced some unexpected behaviour in the L1 dev node tx inclusion. This made flaky L2 integration tests in the CI.
Description
Increase the number of retries to retrieve an L1 tx receipt to a number high enough for the L1 dev to include txs.