- 
                Notifications
    
You must be signed in to change notification settings  - Fork 52
 
Sandboxed cairo native #1209
base: main
Are you sure you want to change the base?
Sandboxed cairo native #1209
Conversation
70edcf2    to
    f897cb7      
    Compare
  
    
          Codecov ReportAttention:  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
+ Coverage   89.07%   89.23%   +0.15%     
==========================================
  Files          52       52              
  Lines       15586    15832     +246     
==========================================
+ Hits        13884    14127     +243     
- Misses       1702     1705       +3     
  | 
    
| )? | ||
| .execute( | ||
| state, | ||
| &BlockContext::default(), | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you re-run the benchmarks? in that case please share the numbers
| @@ -0,0 +1,443 @@ | |||
| use std::{ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this module should be only included if the cairo native feature is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats the case already, please see
#[cfg(feature = "cairo-native")]
pub mod sandboxing;on lib.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments
| 
           Status: Needs to fix ci and yas benchmark being slow when using sandbox.  | 
    
Todo: error reporting
Moved from lambdaclass/cairo_native#417
Checklist