feat(ui): ConfirmButton size + cancelSide props - #15
Closed
jcfrei wants to merge 1 commit into
Closed
Conversation
…-click safety)
For a right-aligned trigger the armed group keeps its right edge, so Cancel must
sit on the right to land under a double-click — add cancelSide ("left"|"right").
size ("sm"|"md") sizes the armed buttons to match a full-size labelled trigger.
Defaults preserve current rendering.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jcfrei
added a commit
that referenced
this pull request
Jul 30, 2026
feat(ui): ConfirmButton size + cancelSide props (#15) Right-aligned triggers keep their right edge when armed, so Cancel goes on the right (cancelSide) to be double-click-safe; size="md" matches a full-size trigger. Defaults unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Released as v0.6.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two opt-in props to
ConfirmButtonso a right-aligned trigger (e.g. a toolbar delete button) is double-click-safe:cancelSide?: "left" | "right"(default"left") — a right-aligned armed group keeps its right edge, so Cancel must be on the right to sit under the trigger's original click point. Left-aligned triggers keep the default.size?: "sm" | "md"(default"sm") —"md"renders normal-height armed buttons to match a full-size labelled trigger;"sm"keeps the compact style for icon triggers.Defaults are unchanged → existing usages (icon trashes) render byte-identical. The consumer (internal CRM lead delete) will pass
size="md" cancelSide="right".🤖 Generated with Claude Code