Add LamderaBadDebugLog error and allow for Debug.log to be converted to noops in lamdera deploys #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when running
lamdera deployorlamdera check, Lamdera no longer requires the user to remove their debug logs, commit, and then try again (before then most likely reverting the commit once the deploy is done).Additionally, the compiler will show an error if the user writes the following code:
Note that this error doesn't appear with just
_ = Debug.logor witha = Debug.log "abc". For_ = Debug.logI just don't think this mistake happens often enough to justify checking for it. And as fora = Debug.log "abc", it's possible that the user could reference this code. Verifying thatais dead code is beyond my expertise.