Update stratigility to 2.2 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerkus
added a commit
to Xerkus/laminas-mvc-middleware
that referenced
this pull request
Mar 27, 2020
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
added a commit
to Xerkus/laminas-mvc-middleware
that referenced
this pull request
Mar 27, 2020
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/update-stratigility
branch
from
b726809 to
84c77cd
Compare
michalbundyra
requested changes
Mar 28, 2020
Member
michalbundyra
left a comment
michalbundyra
left a comment
There was a problem hiding this comment.
@Xerkus in general LGTM, just one small comment, please.
weierophinney
requested changes
Mar 30, 2020
Member
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
Just a couple documentation suggestions; otherwise, looks fine.
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/update-stratigility
branch
from
84c77cd to
2f518d6
Compare
Member
Author
|
@weierophinney @michalbundyra thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates stratigility to 2.2.2, updates tests, deprecates direct usage of double-pass and callable middlewares to mirror stratigility forward-compat changes. No functionality change is brought by this update.