ci: pin nightly toolchain to 2026-04-16 for ethnum 1.5.2 compat#6570
Merged
Conversation
`ethnum 1.5.2` uses `unsafe { mem::transmute(()) }` to create a
`TryFromIntError`, which nightly builds after 2026-04-16 reject
with `error[E0512]` (transmute between types of different sizes).
Pin the nightly toolchain in `linux-build` to `nightly-2026-04-16`
(the last known-good date) until `ethnum` publishes a fix.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
For the medium-term fix, we've submitted an upstream PR to ethnum-rs: nlordell/ethnum-rs#58 The root cause is that Once the upstream fix is released, we can unpin the nightly version in this PR. |
Contributor
Author
|
Thank you @jackye1995 ~ |
2 tasks
Xuanwo
pushed a commit
that referenced
this pull request
May 7, 2026
## Summary Upgrade transitive dependency `ethnum` from 1.5.2 to 1.5.3 and revert the nightly toolchain pin from #6570. Dependency chain: `lance-arrow` → `jsonb 0.5.6` → `ethnum 1.5.3` ## Root Cause `ethnum 1.5.2` used `unsafe { mem::transmute(()) }` to construct `TryFromIntError`, which broke on nightly > 2026-04-16 when `TryFromIntError` grew from 0 to 1 byte on Linux x86_64. `ethnum 1.5.3` ([nlordell/ethnum-rs#58](nlordell/ethnum-rs#58)) replaced all transmute with safe stdlib operations, so the pin is no longer needed. ## Test plan - [x] Verified ethnum 1.5.3 compiles on `nightly-2026-04-18` (the version that broke 1.5.2) in Docker Linux x86_64 - [x] `linux-build` job should pass with unpinned nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
linux-buildCI job installs unpinnednightly, which broke after 2026-04-17 becauseethnum 1.5.2usesunsafe { mem::transmute(()) }to createTryFromIntError. Newer nightly builds reject this witherror[E0512]: cannot transmute between types of different sizes.Dependency chain:
lance-arrow→jsonb 0.5.6→ethnum 1.5.2This PR pins
nightly-2026-04-16(last known-good date) in both the toolchain install step and thecargo +nightlyinvocation.Root Cause
ethnum-1.5.2/src/error.rs:16:Rust nightly
e9e32aca5(2026-04-17) tightenedtransmutechecks, making this a hard error.Follow-up
nlordell/ethnum-rsto replace the transmute hackethnumpublishes a fix andjsonbpicks it up, the pin can be removedTest plan
linux-buildjob passes with pinned nightly