fix: upgrade ethnum 1.5.2 to 1.5.3 and unpin nightly toolchain#6578
Merged
Conversation
ethnum 1.5.3 (nlordell/ethnum-rs#58) replaces the transmute UB in error constructors with safe alternatives, fixing the compilation failure on nightly > 2026-04-16. This reverts the nightly pin introduced in lance-format#6570.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
The failure is unrelated to this PR and has try to fix in #6579 |
Contributor
Author
|
cc @jackye1995 |
Contributor
|
looks like there is a rustdoc fix needed, could you fix along the way? 🙏 |
Contributor
Author
|
Thanks for your review. @jackye1995 The doc fix has been merged: #6579 |
Xuanwo
approved these changes
May 7, 2026
Contributor
Author
|
Thank you @Xuanwo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade transitive dependency
ethnumfrom 1.5.2 to 1.5.3 and revert the nightly toolchain pin from #6570.Dependency chain:
lance-arrow→jsonb 0.5.6→ethnum 1.5.3Root Cause
ethnum 1.5.2usedunsafe { mem::transmute(()) }to constructTryFromIntError, which broke on nightly > 2026-04-16 whenTryFromIntErrorgrew from 0 to 1 byte on Linux x86_64.ethnum 1.5.3(nlordell/ethnum-rs#58) replaced all transmute with safe stdlib operations, so the pin is no longer needed.Test plan
nightly-2026-04-18(the version that broke 1.5.2) in Docker Linux x86_64linux-buildjob should pass with unpinned nightly