fix: tolerate concurrent manifest cleanup - #8213
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The patch addresses the reported list/read race at the right boundary: it uses parsed logical versions, keeps current/newer manifests and non-NotFound failures fatal, and covers deletion between the manifest and index reads.
The production report does not timestamp-confirm the competing deletion, and the test exercises the stale location directly rather than two full concurrent cleanups. An end-to-end concurrency regression would reduce that remaining uncertainty, but the implementation and focused coverage support this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotFoundonly when a manifest listed by cleanup is older than the cleanup snapshot and has been removed concurrently.Root cause
V2 manifest filenames are intentionally encoded as
u64::MAX - version, so18446744073709548523.manifestrepresents logical version 3092 rather than an underflowed version. Two concurrent cleanup calls can race after one lists that old manifest: the other removes it before the first reads it, and the first propagated the resultingNotFound.Validation
cargo test -p lance cleanup_ignores_old_manifest_removed_after_listingcargo test -p lance dataset::cleanup::testscargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #8212