fix(cleanup): reclaim superseded index files promptly - #8323
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The index subtree is now classified while removable manifests can still verify superseded UUIDs, while referenced and recent unknown UUIDs retain their existing protections. Since timestamp filtering happens after recursive listing, this fixes the retention leak without adding object-store listing requests.
Xuanwo
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Cleanup limited every managed subtree to files no newer than the earliest retained manifest. When that cutoff skipped a newer artifact under a superseded index UUID, the same cleanup pass could delete the old manifest that proved the UUID was committed. Later passes then treated the artifact as unverified and retained it for seven days.
Fix
Index cleanup now inspects the full managed index subtree. Referenced UUIDs remain protected, recent UUIDs with no manifest evidence remain protected, and superseded UUIDs verified by manifests scheduled for removal are reclaimed before that evidence disappears.
Validation
cargo test -p lance cleanup_recent_replaced_index_with_short_retentioncargo test -p lance dataset::cleanup::tests::cleanup_(20 passed)cargo fmt --allcargo clippy --all --tests --benches -- -D warningsFixes #8321