Skip to content

fix: compile the lance tests after the compacted_sstables rename - #8440

Merged
Xuanwo merged 1 commit into
lance-format:mainfrom
wombatu-kun:fix/stale-field-in-transaction-tests
Aug 10, 2026
Merged

fix: compile the lance tests after the compacted_sstables rename#8440
Xuanwo merged 1 commit into
lance-format:mainfrom
wombatu-kun:fix/stale-field-in-transaction-tests

Conversation

@wombatu-kun

Copy link
Copy Markdown
Contributor

main does not compile its tests. cargo test -p lance --lib stops at three uses of a field that no longer exists:

error[E0559]: variant `dataset::transaction::Operation::Update` has no field named `merged_generations`
    --> rust/lance/src/dataset/transaction.rs:5453:17
     |
5453 |                 merged_generations: vec![],
     |                 ^^^^^^^^^^^^^^^^^^ `dataset::transaction::Operation::Update` does not have this field
     |
     = note: available fields are: `compacted_sstables`

#7957 renamed that field to compacted_sstables in Operation::Update and in pb::transaction::Update. #7432 was branched before it and its tests still name the old field, so the merge produced code that no compiler had seen: neither branch was wrong on its own base, and git had no textual conflict to report.

All three sites pass an empty list, so they take the new name unchanged. With it, cargo test -p lance --lib dataset::transaction::tests is back to 64 passed.

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

The change updates the three stale test initializers to the current Rust and protobuf field name. It restores the transaction test suite without changing production behavior or wire semantics.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 10, 2026
@wombatu-kun

Copy link
Copy Markdown
Contributor Author

@Xuanwo could you take a look when you have a moment? Test-only, three lines.

Until it lands, CI on every new PR fails for a reason unrelated to that PR: the checks build against the merge with main, and cargo test -p lance --lib does not compile there. lance-gatekeeper has already recommended approval.

@lance-gatekeeper lance-gatekeeper Bot added K-approved Latest Gatekeeper recommendation permits acceptance. and removed K-approved Latest Gatekeeper recommendation permits acceptance. labels Aug 10, 2026
@Xuanwo
Xuanwo merged commit 7173d59 into lance-format:main Aug 10, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants