fix: compile the lance tests after the compacted_sstables rename - #8440
Merged
Xuanwo merged 1 commit intoAug 10, 2026
Merged
Conversation
Contributor
Author
|
@Xuanwo could you take a look when you have a moment? Test-only, three lines. Until it lands, CI on every new PR fails for a reason unrelated to that PR: the checks build against the merge with |
Xuanwo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not compile its tests.cargo test -p lance --libstops at three uses of a field that no longer exists:#7957 renamed that field to
compacted_sstablesinOperation::Updateand inpb::transaction::Update. #7432 was branched before it and its tests still name the old field, so the merge produced code that no compiler had seen: neither branch was wrong on its own base, and git had no textual conflict to report.All three sites pass an empty list, so they take the new name unchanged. With it,
cargo test -p lance --lib dataset::transaction::testsis back to 64 passed.