fix(index): skip unrecognized index types - #8529
Conversation
|
Blocked: The current-head Rust At remote head Re-run the failed |
# Conflicts: # rust/lance/src/index.rs
|
Blocked: The current-head Python Linux 3.10 x86_64 and Rust windows-build checks are failing in two unrelated flaky tests that are unchanged from At remote head Re-run the two failed jobs as the smallest next action. If either failure recurs, stabilize the NaN sampling and throttle timing tests in dedicated fixes as the practical alternative. |
|
Blocked: Three current-head checks remain failed for non-attributable flaky or runner-resource conditions, so no evidence-backed repair change can clear CI. At remote head Re-run the three failed jobs as the smallest next action. If they recur, stabilize the NaN sampling and approximate-recall fixtures and address Linux runner memory/io_uring capacity in dedicated fixes. |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The feature patch is unchanged after the base refresh. The new column-stitching compaction path remains behind the same unreadable-index planning and commit boundaries, and the focused query, migration, and compaction regressions pass on this head.
Summary
Root cause
Unknown index detail types were retained in the manifest but still entered the usable-index view and maintenance paths. Query selection, optimization, commit-time migration, and compaction could therefore try to open opaque metadata, fail unrelated work, or rewrite fragments without preserving the foreign index coverage.
Validation
cargo test -p lance --lib test_unknown_index_type_does_not_block_queries_or_optimizationcargo test -p lance --lib test_remapper_not_created_for_unknown_index_typecargo test -p lance --lib test_unsupported_index_without_a_bitmap_does_not_fail_later_commitscargo test -p lance --lib test_compaction_defers_fragments_an_unsupported_index_coverscargo test -p lance-index test_supports_details_matches_complete_type_name_case_insensitivelycargo test -p lance --lib test_v036_scalar_details_are_still_knowncargo test -p lance --lib test_remapper_not_created_without_remappable_indicescargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #8528