Skip to content

chore: update lance-namespace-reqwest-client to 0.11.0 - #8548

Merged
wkalt merged 2 commits into
lance-format:mainfrom
wkalt:ticket/oss-2044/bump-namespace-client
Aug 14, 2026
Merged

chore: update lance-namespace-reqwest-client to 0.11.0#8548
wkalt merged 2 commits into
lance-format:mainfrom
wkalt:ticket/oss-2044/bump-namespace-client

Conversation

@wkalt

@wkalt wkalt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Picks up the namespace spec computed column surface (AddColumnsEntry.computed,
backfill_column) for downstream SDKs. Every response model gained an optional
context map, so the directory namespace initializers fill remaining fields with
Default::default(); the new num_inserted_rows and version on
InsertIntoTableResponse stay unpopulated there for now.

Picks up the namespace spec computed column surface (AddColumnsEntry.computed,
backfill_column) for downstream SDKs. Every response model gained an optional
context map, so the directory namespace initializers fill remaining fields with
Default::default(); the new num_inserted_rows and version on
InsertIntoTableResponse stay unpopulated there for now.
@github-actions github-actions Bot added A-python Python bindings A-java Java bindings + JNI A-deps Dependency updates A-namespace Namespace impls chore labels Aug 14, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: request changes.

The 0.11.0 bump is the right way to expose the upstream generated models, but its full request contract must be integrated safely: DescribeTableRequest.tag cannot be accepted while silently resolving to the latest table version. Either implement tag resolution and selector validation in directory-backed namespaces, or reject unsupported tagged requests before returning data.

Please mark this PR with the breaking-change label.

Comment thread Cargo.toml
lance-namespace = { version = "=11.0.0-beta.11", path = "./rust/lance-namespace" }
lance-namespace-impls = { version = "=11.0.0-beta.11", path = "./rust/lance-namespace-impls" }
lance-namespace-reqwest-client = "0.8.6"
lance-namespace-reqwest-client = "0.11.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.11.0 also adds DescribeTableRequest.tag, but both directory-backed describe_table paths only inspect request.version. A tagged request therefore succeeds while returning the latest snapshot, so callers can silently get the wrong schema or data. Resolve the tag through the existing tag metadata (and reject combinations with version or branch) before checkout, or reject tag explicitly until the backend supports it.

Reproducer

I ran this temporary regression test against the observed head:

let (namespace, _tmp, table_id) = create_tagged_test_table(3).await;
let mut tag = CreateTableTagRequest::new("v1".into(), 1);
tag.id = Some(table_id.clone());
namespace.create_table_tag(tag).await.unwrap();

let mut describe = DescribeTableRequest::new();
describe.id = Some(table_id);
describe.tag = Some("v1".into());
describe.load_detailed_metadata = Some(true);
let response = namespace.describe_table(describe).await.unwrap();
assert_eq!(response.version, Some(1));
cargo test --locked -p lance-namespace-impls gate_repro_describe_table_honors_tag --all-features -- --nocapture

It failed with left: Some(3), right: Some(1): the latest version was returned instead of the tagged version.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wkalt
wkalt merged commit 25de1e0 into lance-format:main Aug 14, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Dependency updates A-java Java bindings + JNI A-namespace Namespace impls A-python Python bindings chore K-changes Latest Gatekeeper recommendation requests changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants