fix(python): return a shared background executor - #8596
Merged
Conversation
Xuanwo
marked this pull request as ready for review
August 18, 2026 05:25
BubbleCal
approved these changes
Aug 18, 2026
Collaborator
Author
EC2 performance validationTested head The background-executor lookup measured 1.5315 ns at the PR head. The forward delta was -0.007% (95% CI: -0.091% to +0.063%); the reverse comparison was likewise centered at -0.005%. No performance change was detected, so no remediation is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process-wide background executor was exposed as a mutable static reference even though its API only requires shared access. Repeated callers could therefore obtain aliased
&mutreferences to the same executor, violating Rust reference rules. Return a shared reference while preserving the singleton and fork-reinitialization behavior.