ci(spec-sync): apply PR-summary follow-ups (stream-truncate, idempotent edit) - #125
Merged
Merged
Conversation
…nt edit)
Mirror the two Copilot suggestions applied to ade-typescript#92:
- Truncate the diff while streaming (`{ ...; } | head -c`) instead of
buffering the whole (possibly multi-MB) spec diff into a variable first.
- Make the body edit idempotent: skip if a "## What changed" section is
already present, and write via `gh pr edit --body-file -` (stdin) rather
than a large `--body` argument.
Keeps summarize-pr.sh byte-identical to ade-typescript's.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates spec-sync PR summarization to reduce memory usage and make body updates idempotent.
Changes:
- Streams and truncates diffs at 120,000 bytes.
- Prevents duplicate
## What changedsections. - Uses stdin for safe PR body updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to ade-python the two Copilot suggestions already applied to ade-typescript#92 (since #124 was merged):
{ …; } | head -c 120000) instead of buffering it all in memory.## What changedalready present; write via--body-file -.Keeps
scripts/spec-sync/summarize-pr.shbyte-identical across both repos. Verified: byte-identical to #92 final,bash -n+shellcheckclean, stub tests pass (append, idempotent skip).