feat: add V2 production e2e to the release gate - #143
Merged
Conversation
Mirror tests/contract/test_v2_smoke.py against the live production V2 API (api.ade.landing.ai) as tests/contract/test_v2_production.py, marked `production`. Covers parse, extract, ground, and both job types (the soft-hidden build-schema is excluded, matching the staging smoke). The `production` marker means the existing e2e-production.yml run (`pytest -m production`) picks these up automatically, so V2 now gates release alongside V1. Rename the workflow "E2E Production (V1)" -> "E2E Production" and update the cost/label comments accordingly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds V2 production end-to-end coverage to the existing release gate.
Changes:
- Tests V2 parse, extract, ground, and asynchronous jobs against production.
- Reuses the production credential and serial release workflow.
- Renames workflow labels to reflect V1 and V2 coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/contract/test_v2_production.py |
Adds six production V2 tests. |
.github/workflows/e2e-production.yml |
Runs and documents combined V1/V2 coverage. |
.github/workflows/release.yml |
Updates release-gate documentation for V2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the production e2e gate to cover the V2 surface (
client.v2), which previously had only staging smoke coverage. Follow-up to #142 (V1 production e2e).tests/contract/test_v2_production.py— mirrors the staging V2 smoke against the live production V2 host (api.ade.landing.ai),productionmarker:parse,extract,ground, and both job types. The soft-hiddenv2.build_schemais excluded, matching the staging smoke. Shares one parse across the parse/ground tests to hold spend down.productionmarker means the existingpytest -m productionrun picks these up, so V2 gates release automatically.production-e2eenv +LANDINGAI_ADE_PRODUCTION_APIKEYare reused (the same key authenticates both hosts).Trade-off (as discussed): V2 now shares the release gate, so a V2 production issue can block a V1 release, and per-release credit spend roughly doubles.
Verified locally: ruff + pyright clean,
-m productionnow selects 14 tests (8 V1 + 6 V2), suite skips cleanly with no key. Not run against live production (needs the key + spends credits).