Conversation
…s into mcflugen/test-notebooks
|
@mcflugen This is looking great. I love the contributing docs and love the emojis - both your use and the description of proper emoji use - had no idea that was even a thing. Should we highlight that this doc exists? Maybe in the README? And, there should no longer be unexpanded notebooks, right? I found one, so I can just delete it from this branch, right? I also found another empty file that I will boot. Otherwise seems great. |
|
Thanks. I removed the unexpanded notebook (under Glad you like the emojis. I went a little overboard. We don't need to follow the emoji usage guidelines but I thought it was fun. It would also make it easier to categorize our commits if we were to make a change log or to skip CI testing for certain cases (like just documentation changes, for example). |
|
What about referring to the CONTRIBUTING doc in the README? Do you think people will find it? I may underestimate people. |
|
That's a good idea. GitHub is smart enough to see that our repository has a file called |
|
Oh, well never mind then. I didn't know, but guessed it was something special given the all caps which I know you hate. I will commit. |
|
I will wait for tests to finish... |
This pull requests fixes our CI testing of the tutorial notebooks.
Some highlights:
run_notebook.pyto find and run notebooks.tutorial_template.ipynbprovides a template for new tutorials.CONTRIBUTING.mdgives a brief outline about how to contribute to the landlab tutorials, including how the write new tutorials.*_unexpanded.ipynband.pyversions of notebooks.