fix: include non-standard proxy port in drush_uri#180
Merged
AaronFeledy merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
✅ Deploy Preview for lando-drupal ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.
Or push these changes by commenting: Preview (f6c32c1dd1)diff --git a/builders/_drupaly.js b/builders/_drupaly.js
--- a/builders/_drupaly.js
+++ b/builders/_drupaly.js
@@ -305,7 +305,7 @@
let port = '';
if (ports) {
const activePort = ssl ? ports.https : ports.http;
- if (activePort && ((ssl && activePort !== '443') || (!ssl && activePort !== '80'))) {
+ if (activePort && ((ssl && activePort !== 443) || (!ssl && activePort !== 80))) {
port = `:${activePort}`;
}
} |
Member
Author
Applied via @cursor push command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When the Lando proxy falls back to a non-standard port (e.g. 444 instead of 443), the automatically derived
drush_urinow includes the port in the URL.Previously
DRUSH_OPTIONS_URIwould be set tohttps://myapp.lndo.siteeven when the proxy was running on port 444, causing Drush to hit the wrong port. Now it correctly produceshttps://myapp.lndo.site:444.Uses
proxyLastPortsfrom Lando's proxy cache to detect the active port at config time.Note
Low Risk
Small, localized change to derived environment variable construction; risk is limited to incorrect URI generation if proxy port detection is wrong or missing.
Overview
When
drush_uriisn’t explicitly set,_drupalynow buildsDRUSH_OPTIONS_URIfrom the active proxy URL including a non-standard port (e.g.:444) by reading_app._config.proxyLastPortsand only appending the port when it differs from the default for the chosen protocol.This replaces the previous behavior that always emitted a portless
http(s)://<proxyUrl>when inferring the URI from proxy settings.Written by Cursor Bugbot for commit c425a76. This will update automatically on new commits. Configure here.