Skip to content

Port value comparison#181

Closed
cursor[bot] wants to merge 2 commits intomainfrom
cursor/port-value-comparison-4d41
Closed

Port value comparison#181
cursor[bot] wants to merge 2 commits intomainfrom
cursor/port-value-comparison-4d41

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Feb 21, 2026

Bare minimum self-checks

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.


This PR fixes a bug where standard ports (80, 443) could be incorrectly appended to generated URIs. The activePort value from Lando's proxy cache can be a number, but was being strictly compared against string literals. This caused the comparison to always evaluate to true for numeric ports, leading to unnecessary port appending. The fix changes the comparison to use numeric literals to ensure correct behavior regardless of activePort's type.


@cursor
Copy link
Copy Markdown
Author

cursor Bot commented Feb 21, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Base automatically changed from fix/drush-uri-port to main February 22, 2026 02:48
@cursor cursor Bot closed this Feb 22, 2026
@cursor
Copy link
Copy Markdown
Author

cursor Bot commented Feb 22, 2026

Automatically closed this PR because it was created by Bugbot autofix for #180, and that PR was closed.

@cursor cursor Bot deleted the cursor/port-value-comparison-4d41 branch February 22, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants