Skip to content

Port value comparison #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cursor wants to merge 2 commits into from
Closed

Port value comparison #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97fbe04
fix: include non-standard proxy port in drush_uri
AaronFeledy Feb 21, 2026
f6c32c1
Fix port comparison to handle numeric values from proxy cache
cursoragent Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion builders/_drupaly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,17 @@ module.exports = {
// Check SSL setting for the proxy service
const proxyServiceSsl = options.services[options.proxyService]?.ssl;
const ssl = proxyServiceSsl !== undefined ? proxyServiceSsl : options.services.appserver?.ssl;
drushUri = ssl ? `https://${proxyUrl}` : `http://${proxyUrl}`;
const protocol = ssl ? 'https' : 'http';
// Include port if non-standard (e.g. proxy on 444 instead of 443)
const ports = _.get(options, '_app._config.proxyLastPorts');
let port = '';
if (ports) {
const activePort = ssl ? ports.https : ports.http;
if (activePort && ((ssl && activePort !== 443) || (!ssl && activePort !== 80))) {
port = `:${activePort}`;
}
}
drushUri = `${protocol}://${proxyUrl}${port}`;
}
}

Expand Down
Loading