devops: stripe cli in the Brewfile, on both platforms - #66
Merged
Conversation
Owner
Author
|
@claude rebase |
|
Claude finished @landsman's task in 1m 33s —— View job Tasks
ResultI'm unable to perform a If the branch needs to be brought up to date with You can find more information and potential workarounds in the FAQ. If instead you want me to make a specific code change on this branch, just ask and I can push a regular commit. |
Two mise copies on the Mac, active in no config, and nothing on the Linux boxes. The Brewfile takes it over on both. The tap's formula is `depends_on :macos`, so the guard applies and Kubuntu gets it from packages.stripe.dev — the key pinned by fingerprint like every other repo there, and a suite of `stable` rather than a codename, which the test asserts so a later sweep does not paste $CODENAME in. That formula also installs the zsh completion into site-functions, already on fpath from `brew shellenv`, so the three steps `stripe completion` prints — a ~/.stripe directory, an fpath line, its own compinit — are all unnecessary here. The one hand-made copy is deleted, and the Brewfile comment says why the rc files stay silent about it.
The Brewfile comment said it, but the question gets asked at the fpath block, and there it looked like an omission. `stripe completion` prints a ~/.stripe recipe that would duplicate the formula's own _stripe and add a second compinit for zsh-autocomplete to fight; site-functions is already on fpath from `brew shellenv`. Docker Desktop keeps its line because it is not a brew install, which is now the stated rule rather than a coincidence.
…s on Every completion in the Brewfile reaches the shell one way — the formula drops _name into $HOMEBREW_PREFIX/share/zsh/site-functions and `brew shellenv` in .zshrc puts that on fpath. It is the step of the install nobody sees, and it fails silently: move the shellenv line below the completion block and every brew completion goes quiet with no error. So it is asserted now, stripe as the worked example. bin-test's os/*/*.test.sh glob picks it up, so there is no Makefile change. Both failure modes are checked against a broken copy of the rc rather than assumed: the deleted shellenv line, and someone following the recipe `stripe completion` prints (a ~/.stripe on fpath and a second compinit). The first draft passed the deleted-shellenv case — FPATH and HOMEBREW_PREFIX are exported by shellenv, so a run from a configured shell inherits the entry it means to prove. Both are scrubbed, and $HOME is redirected at a temp dir, which also keeps the run from writing a compdump into the real one.
landsman
force-pushed
the
stripe-cli-brewfile
branch
from
August 9, 2026 13:31
312d422 to
cc4a56c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stripewas installed by hand: two mise copies on the Mac, active in no config, and nothing on the Linux boxes. The Brewfile takes it over.The tap's formula is
depends_on :macos, so theif OS.mac?guard applies and Kubuntu gets it frompackages.stripe.devinstead — key pinned by fingerprint like every other repo ininstall-apps.sh. That repo publishes onestablesuite for every release rather than one per codename; the new test case asserts the$CODENAMEis not pasted in, so a later sweep doing it everywhere gets caught.Nothing lands in .zshrc
stripe completionprints three steps — create~/.stripe, add it tofpath, run your owncompinit. None is needed once brew owns the install: the formula puts_stripeinshare/zsh/site-functions, whichbrew shellenvalready has onfpath, and a secondcompinitwould fight zsh-autocomplete for it. The hand-made~/.stripecopy is deleted; the Brewfile comment records why the rc files say nothing.Verified from a real interactive shell — binary at
/opt/homebrew/bin/stripe, completion at/opt/homebrew/share/zsh/site-functions/_stripe.make qapasses.