This repository was archived by the owner on Feb 24, 2026. It is now read-only.
[Do Not Merge] Use compression in file transfer#90
Closed
Lance Martin (rlancemartin) wants to merge 1 commit into
Closed
[Do Not Merge] Use compression in file transfer#90Lance Martin (rlancemartin) wants to merge 1 commit into
Lance Martin (rlancemartin) wants to merge 1 commit into
Conversation
Lance Martin (rlancemartin)
requested review from
Ben Goldberg (benisgold) and
Danil Kolesnikov (dankolesnikov)
May 2, 2023 20:38
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I discovered a security vulnerability in your code. Please take a look and let's address it together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compress files on the client prior to transfer to server.
Odd / unhelpful error b/c I can't see where specifically it is getting thrown by the server.
Logging suggests that it's never getting to here:
Possible problem with the files
files: List[bytes] = File(...),:Trace:
Problem is with FastAPI's File class:
It expects an instance of the
UploadFile class, which provides a read() method to access the contents of the file.Interesting discussion here:
https://stackoverflow.com/questions/73442335/how-to-upload-a-large-file-%E2%89%A53gb-to-fastapi-backend