fix(deepagents): fast-glob follows directory symlink cycles leading to ELOOP crashes#668
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2f1014e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Colin Francis (colifran)
changed the title
ELOOP crashesELOOP crashes
deepagents-acp
deepagents
@langchain/sandbox-standard-tests
@langchain/daytona
@langchain/deno
@langchain/modal
@langchain/node-vfs
@langchain/quickjs
commit: |
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
Hunter Lovell (hntrl)
previously approved these changes
Jul 13, 2026
![corridor-security[bot]](https://avatars.githubusercontent.com/in/1177339?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The fallback literalSearch path in FilesystemBackend follows symlinks when reading file contents via fs.readFile, bypassing the O_NOFOLLOW protection used by read() — an attacker who can plant a symlink inside the workspace can exfiltrate files outside the search root, but only when ripgrep is unavailable.
Merged
Colin Francis (colifran)
pushed a commit
that referenced
this pull request
Jul 13, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## deepagents-acp@0.1.18 ### Patch Changes - Updated dependencies [[`7c8a770`](7c8a770)]: - deepagents@1.10.8 ## deepagents@1.10.8 ### Patch Changes - [#668](#668) [`7c8a770`](7c8a770) Thanks [@colifran](https://github.com/colifran)! - fix(deepagents): fast-glob follows directory symlink cycles leading to ELOOP crashes ## @deepagents/evals@0.0.17 ### Patch Changes - Updated dependencies [[`7c8a770`](7c8a770)]: - deepagents@1.10.8 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast-globfollows symbolic links by default so theglob/greptools inFilesystemBackendandLocalShellBackendwalked directory symlink cycles recursively causingELOOPcrashes. and aborted the run over a target repo.This PR fixes by adding
followSymbolicLinks: falseto all fourfast-globcalls. Bonus: this keeps traversal inside the search root.Tests
Unit tests in
filesystem.test.tsandlocal-shell.test.tsverifying that asub/sub -> .cycle now traverses cleanly without traversing symlinks.This is an upstream fix for: langchain-ai/openwiki#72