Update print statement to use model_dump_json#2296
Merged
Lauren Hirata Singh (lnhsingh) merged 2 commits intoJan 22, 2026
Conversation
'The `json` method is deprecated; the documentation encourage you to use `model_dump_json`, the current example is broken
Rusbel Bermudez (rb-one)
requested a review
from Kathryn May (katmayb)
as a code owner
January 20, 2026 23:01
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates a Python code example to use the current Pydantic API method model_dump_json() instead of the deprecated .json() method, fixing a broken code example in the documentation.
Changes:
- Updated the print statement in the experiment metrics example to use
model_dump_json()instead of the deprecated.json()method
Lauren Hirata Singh (lnhsingh)
approved these changes
Jan 22, 2026
Lauren Hirata Singh (lnhsingh)
merged commit Jan 22, 2026
5a5b526
into
langchain-ai:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update documentation: 'The
jsonmethod is deprecated; the documentation encourage you to usemodel_dump_json, the current example is brokenChecklist
docs devsrc/docs.jsonif needed