fix code cell for streaming#575
Merged
Merged
Conversation
ccurme (ccurme)
requested review from
Kathryn May (katmayb) and
Lauren Hirata Singh (lnhsingh)
as code owners
September 18, 2025 13:37
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken code example for streaming message aggregation in the LangChain documentation. The main issue was that the existing code for combining chunks used an incorrect pattern that resulted in a ChatPromptTemplate instead of an AIMessage.
- Consolidates streaming and chunk aggregation into a single, working code block
- Removes the broken
sum(chunks, AIMessage(""))pattern that produces incorrect results - Demonstrates proper streaming aggregation inline with collection
Contributor
|
Preview ID generated: preview-ccfixs-1758202838-928639b |
Contributor
|
Preview ID generated: preview-ccfixs-1758220102-e6cc573 |
Lauren Hirata Singh (lnhsingh)
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we split the streaming loop and combination into separate code blocks.
There are a few problems with the code block for combining chunks:
Here we demonstrate aggregation in the first cell (and also remove an import).