add snippet js translation missing callout#586
Merged
Conversation
Eugene Yurtsev (eyurtsev)
marked this pull request as ready for review
September 18, 2025 20:07
Eugene Yurtsev (eyurtsev)
requested review from
Kathryn May (katmayb) and
Lauren Hirata Singh (lnhsingh)
as code owners
September 18, 2025 20:07
Contributor
|
Preview ID generated: preview-eugene-1758225995-098199f |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a reusable MDX snippet that provides a callout component to indicate when JavaScript code examples are missing from documentation pages. This snippet will help identify areas where JavaScript translations are needed.
- Adds a new MDX snippet file for JavaScript translation missing callout
- Uses Mintlify's Callout component with appropriate styling and messaging
- Includes a link to the docs repository for contributions
Lauren Hirata Singh (lnhsingh)
approved these changes
Sep 19, 2025
Lauren Hirata Singh (lnhsingh)
left a comment
Collaborator
There was a problem hiding this comment.
I like it!
| @@ -0,0 +1,4 @@ | |||
| <Callout icon="hand-holding-hand" color="#FFC107" iconType="regular"> | |||
| We don’t have this code example in JavaScript yet. Want to help? | |||
There was a problem hiding this comment.
[nitpick] Consider changing 'We don't have' to 'We don't currently have' for clearer communication about the temporary nature of the missing content.
Suggested change
| We don’t have this code example in JavaScript yet. Want to help? | |
| We don’t currently have this code example in JavaScript yet. Want to help? |
Contributor
|
Preview ID generated: preview-eugene-1758290140-ceead96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a snippet for js translations. No need to merge until we need to use it.
Idea is to make sure we have an easy way to identify which code blocks need to be translated!