fix(ci): run Langfuse v4 in dual-write mode - #1795
Merged
Merged
Conversation
hassiebp
marked this pull request as ready for review
July 30, 2026 11:11
|
@claude review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e63e5cbb9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
hassiebp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LANGFUSE_MIGRATION_V4_WRITE_MODE=dualWhy
Langfuse platform v4 is now pulled by default in CI, where the default write mode is
events_only. The Python SDK test suite still intentionally exercises APIs backed by the legacy trace and observation tables, including the experiment runner's dataset-run-item POST request.Dual-write mode populates both the v4 events tables and the legacy tables, allowing CI to validate the current SDK contract against the v4 deployment while the remaining platform compatibility issue is fixed separately.
Scope
This is only a CI deployment configuration change. It does not migrate SDK ingestion, batch evaluation, experiment handling, support helpers, or test expectations to v4-native APIs.
Validation
LANGFUSE_MIGRATION_V4_WRITE_MODE: dualfor bothlangfuse-webandlangfuse-workerCI is the authoritative full-suite validation.
Linear
LFE-14622: Run Python SDK CI against Langfuse v4 in dual-write mode