fix(prompt): compile None value to empty string#556
Merged
hassiebp merged 2 commits intoApr 10, 2024
Merged
Conversation
hassiebp
approved these changes
Apr 10, 2024
hassiebp
changed the base branch from
main
to
hassieb/lfe-759-allow-content-as-promptvar
hassiebp
merged commit 16387dd
into
langfuse:hassieb/lfe-759-allow-content-as-promptvar
Contributor
|
Thanks @fancyweb for your contribution! |
maxdeichmann
added a commit
that referenced
this pull request
Apr 10, 2024
* fix(prompt): compile None value to empty string (#556) Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com> * fix: allows content as prompt variable name * Update test_prompt.py --------- Co-authored-by: Thomas Calvet <calvet.thomas@gmail.com> Co-authored-by: Max Deichmann <m.deichmann@tum.de>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #543 I can now get rid of my own variable interpolation system that circumvented HTML escaping issues 🥳
However, one behavior that I think we should preserve is compiling
Nonevalues to""instead of"None"(as chevron did).