Skip to content

fix(prompt): compile None value to empty string #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Apr 10, 2024
Merged

fix(prompt): compile None value to empty string #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3b887
fix(prompt): compile None value to empty string
fancyweb Apr 10, 2024
737c4b3
Merge branch 'main' into fix/prompt-compil-none
hassiebp Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion langfuse/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ def _compile_template_string(content: str, **kwargs) -> str:

# Append the variable value
if variable_name in kwargs:
result_list.append(str(kwargs[variable_name]))
result_list.append(
str(kwargs[variable_name])
if kwargs[variable_name] is not None
else ""
)
else:
result_list.append(content[var_start : var_end + len(closing)])

Expand Down
7 changes: 7 additions & 0 deletions tests/test_prompt_compilation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ def test_missing_variable():
assert BasePromptClient._compile_template_string(template) == expected


def test_none_variable():
template = "Hello, {{name}}!"
expected = "Hello, !"

assert BasePromptClient._compile_template_string(template, name=None) == expected


def test_strip_whitespace():
template = "Hello, {{ name }}!"
expected = "Hello, John!"
Expand Down