docs: note that log deletion does not erase uploaded files - #933
Merged
Conversation
Adds one sentence to the Log Retention privacy Warning in both audience copies, en/zh/ja. Code-verified: neither conversation deletion nor scheduled log cleanup removes upload_files records or storage objects. Prompted by two enterprise inquiries about attachment lifecycle.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
dosubot
Bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a privacy/retention clarification to the Log Retention warning so readers understand that deleting conversations or cleaning up old logs does not remove user-uploaded files, across both Cloud and Self-host docs in en/zh/ja.
Changes:
- Added a single warning sentence to the Log Retention section in English (Cloud + Self-host).
- Added corresponding Chinese translations (Cloud + Self-host).
- Added corresponding Japanese translations (Cloud + Self-host).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| en/self-host/use-dify/monitor/logs.mdx | Adds retention warning note about uploaded files not being removed by conversation/log deletion. |
| en/cloud/use-dify/monitor/logs.mdx | Same retention warning note for Cloud audience copy. |
| zh/self-host/use-dify/monitor/logs.mdx | Chinese translation of the added retention warning sentence. |
| zh/cloud/use-dify/monitor/logs.mdx | Chinese translation of the added retention warning sentence for Cloud. |
| ja/self-host/use-dify/monitor/logs.mdx | Japanese translation of the added retention warning sentence. |
| ja/cloud/use-dify/monitor/logs.mdx | Japanese translation of the added retention warning sentence for Cloud. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Review fix: the unscoped wording could be read as covering all uploads, but knowledge-document deletion does erase files; only files uploaded in conversations and runs persist.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (6)
zh/self-host/use-dify/monitor/logs.mdx:61
- 这句警告目前只说“不会被一并删除”，可能让读者误解为只是不会从日志/对话界面消失。建议明确说明：上传文件不会从存储中删除。
删除对话或清理过期日志时，其中上传的文件不会被一并删除。
en/self-host/use-dify/monitor/logs.mdx:59
- The new warning sentence uses “erase”, which can read like removing the content from the log UI rather than clarifying that the underlying stored objects remain. Consider explicitly stating that uploaded files are not deleted from storage when conversations/logs are deleted.
Deleting conversations or cleaning up old logs does not erase the files uploaded in them.
en/cloud/use-dify/monitor/logs.mdx:59
- The new warning sentence uses “erase”, which can read like removing the content from the log UI rather than clarifying that the underlying stored objects remain. Consider explicitly stating that uploaded files are not deleted from storage when conversations/logs are deleted.
Deleting conversations or cleaning up old logs does not erase the files uploaded in them.
zh/cloud/use-dify/monitor/logs.mdx:61
- 这句警告目前只说“不会被一并删除”，可能让读者误解为只是不会从日志/对话界面消失。建议明确说明：上传文件不会从存储中删除。
删除对话或清理过期日志时，其中上传的文件不会被一并删除。
ja/self-host/use-dify/monitor/logs.mdx:61
- この文だと「ログ上から消えない」意味にも読めるため、ストレージ上のファイルが削除されないことを明示した方が誤解が少ないです。
会話を削除したり、ログが保持期間を過ぎて削除されたりしても、その中でアップロードされたファイルは消去されません。
ja/cloud/use-dify/monitor/logs.mdx:61
- この文だと「ログ上から消えない」意味にも読めるため、ストレージ上のファイルが削除されないことを明示した方が誤解が少ないです。
会話を削除したり、ログが保持期間を過ぎて削除されたりしても、その中でアップロードされたファイルは消去されません。
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
RiskeyL
added a commit
that referenced
this pull request
Aug 7, 2026
* docs: note that log deletion does not erase uploaded files Adds one sentence to the Log Retention privacy Warning in both audience copies, en/zh/ja. Code-verified: neither conversation deletion nor scheduled log cleanup removes upload_files records or storage objects. Prompted by two enterprise inquiries about attachment lifecycle. * docs: scope the uploaded-files note to conversation uploads Review fix: the unscoped wording could be read as covering all uploads, but knowledge-document deletion does erase files; only files uploaded in conversations and runs persist. (cherry picked from commit 5a316f8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one sentence to the Log Retention privacy Warning in both audience copies, en/zh/ja. Code-verified: neither conversation deletion nor scheduled log cleanup removes upload_files records or storage objects. Prompted by two enterprise inquiries about attachment lifecycle.