Skip to content

variable assigner in workflow only in loop and default behaviour for …#25331

Closed
jubinsoni wants to merge 2 commits into
langgenius:mainfrom
jubinsoni:17942-variable-assigner-in-workflow-only-in-loop
Closed

variable assigner in workflow only in loop and default behaviour for …#25331
jubinsoni wants to merge 2 commits into
langgenius:mainfrom
jubinsoni:17942-variable-assigner-in-workflow-only-in-loop

Conversation

@jubinsoni

Copy link
Copy Markdown
Contributor

…chatflow

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

to fix #17942

Screenshots

Before After
... ...

for workflow(variable assigner node not available when clicked ouside loop node)
Screenshot 2025-09-07 at 6 36 56 PM

for workflow(variable assigner node only available when clicked inside loop node)
Screenshot 2025-09-07 at 6 37 23 PM

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 7, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jubinsoni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the 'Variable Assigner' node was incorrectly available in workflow block selectors outside of loop nodes. It ensures that this node is only selectable when adding blocks within a loop context, improving the user experience and logical consistency of workflow design.

Highlights

  • Variable Assigner Node Visibility: The 'Variable Assigner' node is now conditionally displayed, appearing only when adding blocks within a loop node in a workflow.
  • isInLoop Prop Introduction: A new 'isInLoop' boolean prop has been introduced and propagated through various UI components (NodeSelector, Blocks, Tabs, CustomEdge, NodeHandle, etc.) to correctly determine the current context (inside or outside a loop).
  • Fix for Issue #17942: This change directly resolves the reported issue where the variable assigner node was incorrectly available outside loop nodes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot Bot added the 🌊 feat:workflow Workflow related stuff. label Sep 7, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to restrict the 'Variable Assigner' node to be available only within a loop in workflow mode. This is achieved by introducing an isInLoop prop and passing it down through various components to where the block filtering logic resides. The changes are well-contained and consistently applied. My review includes a suggestion to improve the performance and correctness of the filtering logic.

@jubinsoni

Copy link
Copy Markdown
Contributor Author

closing this and opening a new pr

@jubinsoni jubinsoni closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement/Refactor] Variable Assigner Node visibility conditions

1 participant