Skip to content

fix: Fix RAG pipeline identifier name dash format#25438

Merged
WTW0313 merged 1 commit into
feat/rag-2from
fix/document-list-icon
Sep 9, 2025
Merged

fix: Fix RAG pipeline identifier name dash format#25438
WTW0313 merged 1 commit into
feat/rag-2from
fix/document-list-icon

Conversation

@WTW0313

@WTW0313 WTW0313 commented Sep 9, 2025

Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings September 9, 2025 10:42
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 9, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the RAG pipeline identifier name format by changing the dash convention from underscore to dash format. The issue appears to be a mismatch in the identifier format used when checking if content was created from a RAG pipeline.

  • Fixed the RAG pipeline identifier string comparison from underscore to dash format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @WTW0313, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor naming inconsistency by updating the format of the RAG pipeline identifier. The change ensures that the application uses a consistent naming convention for these identifiers, improving code readability and maintainability.

Highlights

  • RAG Pipeline Identifier Naming: This PR standardizes the identifier name for RAG pipelines from "rag_pipeline" to "rag-pipeline" within the DocumentList component, ensuring consistent naming conventions across the application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@QuantumGhost
QuantumGhost self-requested a review September 9, 2025 10:43
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2025
@WTW0313
WTW0313 merged commit e1ecce8 into feat/rag-2 Sep 9, 2025
@WTW0313
WTW0313 deleted the fix/document-list-icon branch September 9, 2025 10:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the string identifier for documents created via a RAG pipeline from rag_pipeline to rag-pipeline. The change itself is simple and effective.

My review includes one suggestion to improve maintainability by replacing the magic string with a constant.

Additionally, I've noticed that the rag_pipeline identifier is still used in other parts of the codebase (e.g., DataSet.runtime_mode in web/models/datasets.ts). For overall consistency, it would be beneficial to check if these other occurrences should also be updated to use the new dash format, perhaps in a follow-up pull request.


const isCreateFromRAGPipeline = useCallback((createdFrom: string) => {
return createdFrom === 'rag_pipeline'
return createdFrom === 'rag-pipeline'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid the use of magic strings, consider defining 'rag-pipeline' as a constant in a shared location (like web/models/datasets.ts) and referencing it here. This makes the code easier to understand and manage, especially if this identifier is used in multiple places or needs to be changed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants