fix: progress bar issue#2957
Merged
Merged
Conversation
dosubot
Bot
added
the
size:XS
crazywoola
requested changes
Mar 25, 2024
Member
There was a problem hiding this comment.
There is no actual changes of package.json, so this should not be committed into the vc system.
Contributor
Author
There was a problem hiding this comment.
I ran yarn upgrade next-nprogress-bar and it didn't change the package.json file. Should I update the package.json file?
Member
There was a problem hiding this comment.
Yes, in this case you should change the deps as well.
Contributor
Author
There was a problem hiding this comment.
I've updated the deps.
Member
|
Hello please add my wechat crazyphage I will invite you to the contributors' group. |
crazywoola
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the
/datasetspage, clicking on a delete icon triggers the unexpected appearance of the progress bar. The latest version of thenext-nprogress-barpackage provides a solution to this issue. However, it might be worth considering redesigning theDatasetCardcomponent, as encapsulating numerous elements within a singleLinkcomponent is not considered a best practice.Type of Change
Please delete options that are not relevant.