Skip to content

fix: picker style error#30302

Merged
crazywoola merged 28 commits into
langgenius:feat/vibe-wffrom
ZeroZ-lab:feat-vibe-wf
Dec 29, 2025
Merged

fix: picker style error#30302
crazywoola merged 28 commits into
langgenius:feat/vibe-wffrom
ZeroZ-lab:feat-vibe-wf

Conversation

@ZeroZ-lab

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... CleanShot 2025-12-29 at 12 56 56

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

crazywoola and others added 27 commits December 26, 2025 11:23
…lity

- Added `bananaCommand` to handle vibe-related actions, including search and command registration.
- Updated `command-selector` to utilize new internationalization maps for slash commands and scope actions.
- Removed deprecated banana action from the actions index and adjusted related filtering logic.
- Added unit tests for the banana command to ensure correct behavior in various scenarios.
- Deleted obsolete banana action tests and files.
- Introduced a new `constants.ts` file to centralize action keys and i18n mappings for slash commands and scope actions.
- Updated `command-selector` and various action files to utilize the new constants for improved maintainability and readability.
- Removed hardcoded strings in favor of the new mappings, ensuring consistency across the application.
- Updated `useVibeFlowData` to prevent adding empty graphs and ensure the current version is correctly derived from available versions.
- Improved error handling in `applyFlowchartToWorkflow` to notify users when the current flow graph is invalid.
- Added checks to only add valid workflow graphs to the versions list, enhancing data integrity.
…tem, simplifying command management and registration.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 29, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ZeroZ-lab, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but important UI adjustment to the VibePanel component. The change specifically addresses the stacking context of the panel, ensuring it renders at the correct z-index level to prevent visual overlaps with other interface elements, thereby improving the overall user experience.

Highlights

  • UI Z-index Adjustment: The VibePanel component's stacking order has been updated by replacing the highPriority prop with a wrapperClassName setting a z-[900] Tailwind CSS class. This ensures the panel appears correctly above other UI elements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot Bot added the 🌊 feat:workflow Workflow related stuff. label Dec 29, 2025
@ZeroZ-lab ZeroZ-lab changed the title Feat vibe wf feat fix style error Dec 29, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adjusts the z-index of the VibePanel modal by replacing the highPriority prop with a specific wrapperClassName. This change correctly resolves a visual layering bug where a nested modal was hidden. My feedback focuses on improving code maintainability by suggesting the addition of a comment to explain the choice of the new z-index value, which is currently a magic number.

Comment thread web/app/components/workflow/panel/vibe-panel/index.tsx
@crazywoola crazywoola changed the title feat fix style error fix: picker style error Dec 29, 2025
@crazywoola
crazywoola merged commit df1715a into langgenius:feat/vibe-wf Dec 29, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants