Skip to content

fix: disable httpx proxy for plugin daemon requests#33558

Open
hikariming wants to merge 1 commit intolanggenius:mainfrom
hikariming:fix/httpx-trust-env
Open

fix: disable httpx proxy for plugin daemon requests#33558
hikariming wants to merge 1 commit intolanggenius:mainfrom
hikariming:fix/httpx-trust-env

Conversation

@hikariming
Copy link
Copy Markdown
Contributor

Problem

When running Dify from source on macOS (or other systems with proxy configurations), httpx may attempt to use system proxy settings for localhost requests to the plugin daemon. This causes connection failures with errors like:

httpx.RemoteProtocolError: Server disconnected without sending a response

or

{"code":-401,"message":"unauthorized"}

Root Cause

The httpx.request() and httpx.stream() functions default to trust_env=True, which reads proxy settings from environment variables. Even when system proxy is shown as "disabled" in macOS settings, httpx may still attempt to route localhost traffic through a proxy.

Solution

Add trust_env=False parameter to httpx calls for plugin daemon API requests. Since these are internal network calls to localhost, they should never go through a proxy.

Testing

Tested locally with:

  • Dify API running from source (flask run)
  • Plugin daemon running in Docker
  • Chatflow API calls working correctly after the fix

Changes

  • api/core/plugin/impl/base.py: Added trust_env=False to httpx.request() and httpx.stream() calls

When running Dify from source on macOS, httpx may attempt to use
system proxy settings for localhost requests to plugin daemon,
causing connection failures with 'Server disconnected without response'.

This fix disables proxy environment variables for internal plugin
daemon API calls by setting trust_env=False.

Fixes: plugin daemon connection issues in local development environment
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 17, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where httpx, when running Dify from source, would attempt to use system proxy settings for internal localhost requests to the plugin daemon. This behavior led to connection failures and errors. The solution ensures that these internal calls bypass any proxy configurations by explicitly disabling environment proxy trust, thereby stabilizing communication with the plugin daemon.

Highlights

  • Proxy Configuration Fix: Disabled httpx from using system proxy settings for internal plugin daemon requests by explicitly setting trust_env=False.
  • Connection Stability: Resolved httpx.RemoteProtocolError and unauthorized errors that occurred when httpx incorrectly routed localhost traffic through a proxy.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • api/core/plugin/impl/base.py
    • Added trust_env=False to the httpx.request() call within the _request function.
    • Added trust_env=False to the httpx.stream() call within the _stream_request function.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables proxy usage for httpx requests made to the plugin daemon by setting trust_env=False. This is intended to fix connection failures on systems with system-wide proxy settings. The changes are applied to both regular and streaming requests in api/core/plugin/impl/base.py. The implementation correctly applies the trust_env=False parameter to the httpx.request and httpx.stream calls.

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

No changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant